Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(utils): use Array.flat() in flatten() #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hobbitronics
Copy link

@hobbitronics hobbitronics commented Jun 20, 2024

Changed

  • use Array.prototype.flat() in utils.flatten

Copy link

@davidaucoin7377 davidaucoin7377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Copy link
Contributor

@mrmlnc mrmlnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mrmlnc
Copy link
Contributor

mrmlnc commented Jan 5, 2025

@jonschlinkert, you have a plan to remove support for older versions of node.js? The .flat method available starting with [email protected].

@jonschlinkert
Copy link
Member

Yes, we can remove support for older versions. LGTM

@hobbitronics
Copy link
Author

This might change your performance numbers mentioned in the README.

@jonschlinkert
Copy link
Member

FWIW, while I'm always in favor of making improvements, the reason I don't generally like this kind of PR is that this is a zero-sum exchange at best. This will trigger thousands or potentially millions of cascading PRs for people to patch their libraries, and the aggregate manual effort and computes consumed in the process will almost certainly "cost" more than what you think is being saved by removing the dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants