-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(utils): use Array.flat() in flatten() #45
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@jonschlinkert, you have a plan to remove support for older versions of node.js? The |
Yes, we can remove support for older versions. LGTM |
This might change your performance numbers mentioned in the README. |
FWIW, while I'm always in favor of making improvements, the reason I don't generally like this kind of PR is that this is a zero-sum exchange at best. This will trigger thousands or potentially millions of cascading PRs for people to patch their libraries, and the aggregate manual effort and computes consumed in the process will almost certainly "cost" more than what you think is being saved by removing the dependency. |
Changed