Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syn to v2 #126

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Update syn to v2 #126

merged 1 commit into from
Sep 9, 2023

Conversation

jonasbb
Copy link
Contributor

@jonasbb jonasbb commented Apr 27, 2023

This is one of a couple of my dependencies still requiring syn v1. So I took the liberty to update it to v2.

The only change necessary was replacing the code using NestedMeta, since that type is no longer available in syn. I replaced it with Attribute::parse_nested_meta.

Replace removed `NestedMeta` with `Attribute::parse_nested_meta`.
@lopopolo
Copy link
Contributor

@mgeisler friendly ping here. I'd love to see this merged. version-sync is the only crate left in my lockfiles that pulls in syn v1

Copy link
Owner

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton and I'm sorry that this fell off my radar!

@mgeisler mgeisler merged commit 7e68cea into mgeisler:master Sep 9, 2023
@github-actions github-actions bot mentioned this pull request Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants