add Julia support #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I will test it out soon, I will merge it soon if everything works as expected. Thank you so much, this is a great PR. |
metrue
reviewed
Nov 21, 2017
There was a problem hiding this comment.
@mbesancon everyting works great during my test on the PR.
Please check the comments I wrote, I merge it to master as you finished it.
images/julia/Dockerfile
Outdated
| RUN julia /app/deps.jl | ||
|
|
||
| CMD julia /app/app.jl | ||
| EXPOSE 8080 |
There was a problem hiding this comment.
@mbesancon can you expose 3000 instead 8080, let's keep same port like the other Dockerfile of fx/images
There was a problem hiding this comment.
Yep, I'll change that tomorrow
images/julia/app.jl
Outdated
| end | ||
| end | ||
|
|
||
| run(srv, 8080) |
update from main repo
|
@metrue I changed the port in the Docker and app.jl to 3000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just as #31 this is a first draft to add Julia support. The core fx package was not yet modified.
An example function was added in example, using a typed interface with an Input struct.
images/juliacontains an app.jl using a minimalist HTTP server, the function file and the docker image.