Feature/docker params #538
Conversation
| @@ -171,7 +171,18 @@ class JobDeserializer extends JsonDeserializer[BaseJob] { | |||
| if (containerNode.has("forcePullImage") && containerNode.get("forcePullImage") != null) | |||
| Try(containerNode.get("forcePullImage").asText.toBoolean).getOrElse(false) | |||
| else false | |||
| container = DockerContainer(containerNode.get("image").asText, volumes, networkMode, forcePullImage) | |||
|
|
|||
There was a problem hiding this comment.
Small nit: can you drop the extra newline?
|
One tiny comment, but it otherwise looks great. Once you update the PR, I'll merge it. |
|
Thanks @brndnmtthws for having a look. I dropped the double newlines, but I kept a single newline as a visual separator. I hope that's what you meant. |
|
Yep, looks good! |
|
@brndnmtthws, @gkleiman any chance to get a new release with this feature? It's been a while since 2.4.0. |
|
Same here, I'd really like to use a released version with this feature. |
|
scheduler/jobs doesn't return the custom container parameters |
|
@vivekkothari is it because this feature hasn't been released? |
|
@m1k3, which release is this feature available in? |
|
AFAIK it wasn't released yet as the latest release 2.4.0 was released before this feature was merged. |
|
Until it's released one workaround is to start you docker container by yourself with a chronos command, then you can use any specific config or param. |
|
v2.5.0 has been released with the changes in this PR. |
Implementing a generic way of passing in docker params the same way marathon does it.
references #536
cc/ @strzelecki-maciek