Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config_LINUX_INTEL.mk #30

Merged
merged 1 commit into from
May 13, 2024
Merged

Update config_LINUX_INTEL.mk #30

merged 1 commit into from
May 13, 2024

Conversation

A-CGray
Copy link
Member

@A-CGray A-CGray commented May 12, 2024

Purpose

Equivalent to mdolab/pyhyp#87, required for https://github.com/mdolab/docker/pull/266

Expected time until merged

1 day

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray A-CGray requested a review from a team as a code owner May 12, 2024 15:21
@A-CGray A-CGray requested review from anilyil, sseraj and eirikurj and removed request for anilyil May 12, 2024 15:21
Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.11%. Comparing base (725b16c) to head (3d55858).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   50.11%   50.11%           
=======================================
  Files           5        5           
  Lines        1688     1688           
=======================================
  Hits          846      846           
  Misses        842      842           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@A-CGray A-CGray requested a review from hajdik May 13, 2024 18:56
@sseraj sseraj merged commit bf73e00 into main May 13, 2024
12 checks passed
@sseraj sseraj deleted the A-CGray-patch-1 branch May 13, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants