Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added coverage reporting #31

Merged
merged 3 commits into from
Aug 24, 2021
Merged

Added coverage reporting #31

merged 3 commits into from
Aug 24, 2021

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Aug 23, 2021

Purpose

Added codecov coverage. I also added a few entries to the gitignore file.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner August 23, 2021 20:45
@sseraj sseraj requested review from ewu63 and joanibal August 23, 2021 20:45
@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@95a103e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #31   +/-   ##
=========================================
  Coverage          ?   60.55%           
=========================================
  Files             ?        5           
  Lines             ?     1610           
  Branches          ?        0           
=========================================
  Hits              ?      975           
  Misses            ?      635           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95a103e...1cfcbc3. Read the comment docs.

@ewu63 ewu63 requested a review from akleb August 23, 2021 21:00
@@ -2,4 +2,4 @@
set -e
cp $CONFIG_FILE config/config.mk
make
pip install .
pip install -e .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we doing this on all our repos now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so because it's necessary for codecov to work properly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fairly certain that we don't need to do this (it's kinda silly to enforce all coverage testing to be installed in developer mode) but I haven't had time to figure out how to do it otherwise.

@akleb akleb merged commit 3260102 into mdolab:master Aug 24, 2021
@sseraj sseraj deleted the coverage branch August 24, 2021 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants