Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix writeVolumeMeshPoints #84

Merged
merged 2 commits into from
Aug 19, 2023
Merged

fix writeVolumeMeshPoints #84

merged 2 commits into from
Aug 19, 2023

Conversation

mtowara
Copy link
Contributor

@mtowara mtowara commented Aug 11, 2023

moved to pyOFM, fixes #80

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

moved to pyOFM, fixes mdolab#80
@mtowara mtowara requested a review from a team as a code owner August 11, 2023 12:09
@mtowara mtowara requested review from anilyil and sseraj August 11, 2023 12:09
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #84 (57e2e40) into main (ebcb939) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   73.50%   73.31%   -0.20%     
==========================================
  Files           6        6              
  Lines         755      757       +2     
==========================================
  Hits          555      555              
- Misses        200      202       +2     
Files Changed Coverage Δ
idwarp/UnstructuredMesh.py 62.44% <0.00%> (-0.30%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sseraj
sseraj previously approved these changes Aug 11, 2023
@sseraj sseraj requested review from bernardopacini and removed request for anilyil August 11, 2023 13:39
Copy link
Collaborator

@bernardopacini bernardopacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @friedenhe is this fix fine for you as well?

@friedenhe
Copy link
Collaborator

friedenhe commented Aug 19, 2023

@bernardopacini The new change looks good to me.

@sseraj sseraj merged commit 5e631ab into mdolab:main Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to write grid
4 participants