Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in multi us mesh initialization #81

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Bugfix in multi us mesh initialization #81

merged 3 commits into from
Sep 27, 2023

Conversation

anilyil
Copy link
Contributor

@anilyil anilyil commented Jul 20, 2023

Purpose

The initialization of MultiUSMesh makes a few os.system calls to overwrite BCs. In my working docker container, this caused MPI problems where somehow the code was calling MPI init again from the os.system call. To avoid this, I changed the initialization to just load the cgns grid, overwrite BCs, and write the grid back out, which is what cgns_utils does anyways so this is more efficient too.

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@anilyil anilyil requested a review from a team as a code owner July 20, 2023 18:17
@anilyil anilyil requested review from lamkina, awccopp, sseraj and ArshSaja and removed request for lamkina and awccopp July 20, 2023 18:17
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #81 (a7f36a5) into main (2c4769b) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   73.31%   73.42%   +0.10%     
==========================================
  Files           6        6              
  Lines         757      760       +3     
==========================================
+ Hits          555      558       +3     
  Misses        202      202              
Files Coverage Δ
idwarp/MultiUnstructuredMesh.py 84.84% <100.00%> (+0.17%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ArshSaja
Copy link
Contributor

I ran the multi us mesh with the OWN. It initializes and runs fine.

@sseraj sseraj merged commit 0c8f01a into mdolab:main Sep 27, 2023
@anilyil anilyil deleted the work branch September 28, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants