Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed denominator typos #77

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Fixed denominator typos #77

merged 1 commit into from
Oct 11, 2022

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Oct 11, 2022

Purpose

The word "denominator" was misspelled as "denomenator" throughout the code, so I fixed it.

Expected time until merged

2-3 days

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner October 11, 2022 17:54
@sseraj sseraj requested review from joanibal and lamkina October 11, 2022 17:54
Copy link

@lamkina lamkina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that isn't the Canadian spelling?

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #77 (41e249f) into main (1609dca) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage   73.43%   73.43%           
=======================================
  Files           6        6           
  Lines         753      753           
=======================================
  Hits          553      553           
  Misses        200      200           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ewu63 ewu63 merged commit 9ccc301 into main Oct 11, 2022
@ewu63 ewu63 deleted the denom-typo branch October 11, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants