Update library import checks #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
=======================================
Coverage 73.43% 73.43%
=======================================
Files 6 6
Lines 753 753
=======================================
Hits 553 553
Misses 200 200 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sseraj
reviewed
Oct 4, 2022
|
Ugh, right, the |
sseraj
reviewed
Oct 4, 2022
| parser.add_argument( | ||
| "name", | ||
| type=str, | ||
| help="Library name (example: libpackage.so). Note: This script must be run in the same dir as the library.", |
There was a problem hiding this comment.
The note is not true anymore, right?
There was a problem hiding this comment.
Actually, I think I misinterpreted this. It makes sense now.
sseraj
previously approved these changes
Oct 4, 2022
ewu63
approved these changes
Oct 4, 2022
sseraj
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Currently, the library import check suppresses useful information why the library could not be imported. This PR updates the import check to print out the full error message.
Expected time until merged
No rush.
Type of change
Testing
Compile the module with and without the fix, with a broken library (e.g., by commenting out
CGNS_LINKER_FLAGSin the config).Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable