-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AD code structure #62
Conversation
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=======================================
Coverage 45.80% 45.80%
=======================================
Files 6 6
Lines 751 751
=======================================
Hits 344 344
Misses 407 407 Continue to review full report at Codecov.
|
I left two broader comments about the PR. I think the changes are fine, but since we are refactoring things now it may be worth making these small changes too while we are here. Since I worked with you (@nwu63) on this, we should have at least one more person who knows about Tapenade review this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, but then again, I am no expert on any of the files that have changes. My only broad comment would be to be careful about a possible parallel make. I am not sure if tapenade makefiles even do that, but just something that can cause race conditions with the addition and removal of temp files. If what I am saying is completely unrelated, then this PR is probably good to go for me.
As far as I know, Tapenade does not support that kind of parallelism and we do not use it anywhere even if it does. I don't think we have to worry about this, Tapenade handles IO itself and our preprocessing is serial in the makefile. Tapenade is realistically pretty quick so I think that we should avoid parallelism in the future even if it does exist -- not worth the extra effort. If Tapenade is parallel within the executable that's fine, it shouldn't change anything for our makefile. |
Okay, then it looks good on my end. We need 2 approvals to merge I think. |
Purpose
I updated the entire AD code structure:
adjoint
directory where AD-related code is located in<something>.F90_b.f90
filename issue with 3.16.Type of change
Testing
This PR just changes the AD build process. Existing tests should pass.
Checklist
flake8
andblack
to make sure the code adheres to PEP-8 and is consistently formatted