Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codecov #60

Merged
merged 6 commits into from
Sep 5, 2021
Merged

Update codecov #60

merged 6 commits into from
Sep 5, 2021

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Aug 25, 2021

Purpose

This PR does the same thing as mdolab/pygeo#99:

  • no longer install package in place
  • run tests in the test directory instead of the root.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

@ewu63 ewu63 requested a review from a team as a code owner August 25, 2021 22:46
@ewu63 ewu63 requested review from SichengHe and joanibal August 25, 2021 22:46
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #60 (58e7d35) into master (1e1d6a5) will decrease coverage by 0.32%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   46.13%   45.80%   -0.33%     
==========================================
  Files           6        6              
  Lines         776      751      -25     
==========================================
- Hits          358      344      -14     
+ Misses        418      407      -11     
Impacted Files Coverage Δ
idwarp/MultiUnstructuredMesh.py 8.23% <0.00%> (-0.38%) ⬇️
idwarp/UnstructuredMesh.py 61.03% <40.00%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e1d6a5...58e7d35. Read the comment docs.

@marcomangano
Copy link
Contributor

@nwu63 is this ready to be merged?

@ewu63
Copy link
Collaborator Author

ewu63 commented Sep 2, 2021

@nwu63 is this ready to be merged?

Yep, I just didn't wanna do it without all the required reviews.

@ewu63 ewu63 merged commit 07a0f97 into master Sep 5, 2021
@marcomangano marcomangano deleted the update-codecov branch September 5, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants