Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate compile flags #59

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Consolidate compile flags #59

merged 2 commits into from
Aug 25, 2021

Conversation

eirikurj
Copy link
Contributor

@eirikurj eirikurj commented Aug 5, 2021

Purpose

Previously, flags were included twice when compiling. This PR consolidates and simplifies the flags used.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Tested locally.

Checklist

Put an x in the boxes that apply.

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj eirikurj requested a review from a team as a code owner August 5, 2021 15:47
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #59 (d8eb2e1) into master (1139b7d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   46.13%   46.13%           
=======================================
  Files           6        6           
  Lines         776      776           
=======================================
  Hits          358      358           
  Misses        418      418           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1139b7d...d8eb2e1. Read the comment docs.

Copy link
Collaborator

@ewu63 ewu63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think we will want to do this for some other repos too right?

@ewu63 ewu63 merged commit 1e1d6a5 into master Aug 25, 2021
@ewu63 ewu63 deleted the buildFlags branch August 25, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants