Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating config files to use the more modern wrappers #58

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Conversation

eirikurj
Copy link
Contributor

@eirikurj eirikurj commented Jul 15, 2021

Purpose

Updates the compilers wrappers used. Now the more modern fortran mpi compiler wrapper mpifort used instead of the mpif90, see here for GNU and similarly for Intel mpiifort, see here

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Tested on c7-intel-impi-latest and u20-gcc-ompi-latest

Checklist

Put an x in the boxes that apply.

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj eirikurj requested a review from a team as a code owner July 15, 2021 18:32
@codecov
Copy link

codecov bot commented Jul 17, 2021

Codecov Report

Merging #58 (499749a) into master (834f8ae) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   46.13%   46.13%           
=======================================
  Files           6        6           
  Lines         776      776           
=======================================
  Hits          358      358           
  Misses        418      418           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 834f8ae...499749a. Read the comment docs.

@eirikurj eirikurj requested a review from joanibal July 23, 2021 12:06
Copy link
Collaborator

@joanibal joanibal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the TACC's containers still work, I'm fine with this.

@eirikurj
Copy link
Contributor Author

There should be no issues with TACC as the mpifort and mpif90 are the same wrapper. The build and tests also pass on TACC image.

@ewu63 ewu63 merged commit 136b3bb into master Jul 26, 2021
@ewu63 ewu63 deleted the update_conf branch July 26, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants