Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MExt #49

Merged
merged 3 commits into from
Apr 12, 2021
Merged

Fix MExt #49

merged 3 commits into from
Apr 12, 2021

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Apr 5, 2021

Purpose

Previously MExt used to raise a lot of resource warnings regarding unclosed files. This PR fixes it by switching from imp to importlib since the former is deprecated. I also made some other minor adjustments to the code to improve readability/code quality.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Code that runs IDwarp will not receive ResourceWarning anymore.

Checklist

Put an x in the boxes that apply.

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewu63 ewu63 requested a review from a team as a code owner April 5, 2021 22:26
@ewu63 ewu63 requested review from shamsheersc19 and joanibal April 5, 2021 22:26
@ewu63 ewu63 merged commit 97b540e into master Apr 12, 2021
@ewu63 ewu63 deleted the fix-MExt branch April 12, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants