Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed old tests #41

Merged
merged 3 commits into from
Jan 25, 2021
Merged

Removed old tests #41

merged 3 commits into from
Jan 25, 2021

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Jan 23, 2021 •
edited
Loading

Purpose

I removed the old tests, since they are no longer used. I guess we forgot to do this in #36.

I also changed printCurrentOptions to printOptions to reflect changes in baseclasses.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

@ewu63 ewu63 requested a review from a team as a code owner January 23, 2021 21:20
@sseraj
Copy link
Collaborator

sseraj commented Jan 24, 2021

Should we require mdolab-baseclasses>=1.4 for printOptions?

@ewu63
Copy link
Collaborator Author

ewu63 commented Jan 24, 2021

Good catch

@joanibal joanibal merged commit a748a27 into master Jan 25, 2021
@joanibal joanibal deleted the remove-old-tests branch January 25, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanibal joanibal joanibal approved these changes

@eirikurj eirikurj eirikurj approved these changes

@SichengHe SichengHe Awaiting requested review from SichengHe

@Xiaosong2105 Xiaosong2105 Awaiting requested review from Xiaosong2105

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ewu63 @sseraj @joanibal @eirikurj