use setup.py #21
Merged
use setup.py #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanibal
requested review from
SichengHe,
Xiaosong2105,
ewu63 and
eirikurj
and removed request for
SichengHe and
Xiaosong2105
ewu63
requested changes
Jun 12, 2020
ewu63
reviewed
Jun 15, 2020
| 'idwarp': ['*.so'] | ||
| }, | ||
| install_requires=[ | ||
| 'numpy>=1.16.4', |
eirikurj
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Change the structure of the repo to use the
setup.pymethod of installation.This will make it easier to install environment specific packages and specify dependencies.
One can install the repo now by doing
make(if applicable) andpip install .Type of change
Checklist