Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the APIs for the pyOFM repo. #18

Merged
merged 1 commit into from
May 4, 2020
Merged

Changed the APIs for the pyOFM repo. #18

merged 1 commit into from
May 4, 2020

Conversation

friedenhe
Copy link
Collaborator

@friedenhe friedenhe commented May 3, 2020 •
edited
Loading

Purpose

The IO functions in pyOFM has been wrapped using Cython. We need to change the APIs in IDWarp.

Type of change

What types of change is it?

  • Code style update (formatting, renaming)

Testing

I have added the tests in pyOFM repo.

Checklist

Put an x in the boxes that apply.

  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@friedenhe friedenhe requested a review from a team as a code owner May 3, 2020 01:09
@friedenhe friedenhe requested review from joanibal and Xiaosong2105 May 3, 2020 01:09
@joanibal joanibal merged commit f854b65 into mdolab:master May 4, 2020
@friedenhe friedenhe deleted the pyofm_api branch May 5, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanibal joanibal joanibal approved these changes

@Xiaosong2105 Xiaosong2105 Xiaosong2105 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@friedenhe @joanibal @Xiaosong2105