Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency on openfoammeshreader #17

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

friedenhe
Copy link
Collaborator

@friedenhe friedenhe commented Apr 27, 2020

Purpose

Change the name of openfoammeshreader to pyofm and remove the reg test dependency on it. The test has been moved to pyofm and will be tested there.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)

Testing

The test1 in idwarp has been commented out. It will be tested in pyofm instead.

Checklist

Put an x in the boxes that apply.

  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@friedenhe friedenhe requested a review from a team as a code owner April 27, 2020 15:36
Copy link
Collaborator

@Xiaosong2105 Xiaosong2105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you tell how test case 1 is different from the other regression tests, please?
You moved test case 1 only, but left the other cases unchanged.
Also, in the original code, test 1 is run under the condition of "try ... except".
Why is that?

@friedenhe
Copy link
Collaborator Author

The only difference between test1 and others is that test1 uses the openfoammeshreader to read OpenFOAM meshes, while others read cgns meshes. We want to remove the dependency of idwarp's reg test on openfoammeshreader. test1 will be moved to the openfoammeshreader repo. So test1 is commented out, but we do want to test idwarp handling cgns meshes. I posted something on slack about it.

Copy link
Collaborator

@Xiaosong2105 Xiaosong2105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks!

Copy link
Collaborator

@ewu63 ewu63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I did test locally and everything worked (without test1 of course).

@ewu63 ewu63 merged commit 65ced79 into mdolab:master Apr 27, 2020
@friedenhe friedenhe deleted the fix_pyOFM branch May 2, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants