Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat update #37

Merged
merged 3 commits into from
Mar 14, 2025
Merged

Chat update #37

merged 3 commits into from
Mar 14, 2025

Conversation

Horiodino
Copy link
Contributor

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

To allow user to update chat.

Which issue(s) this PR fixes:

Fixes #30 (comment)

Special notes for your reviewer:

Does this PR introduce a user-facing change?

mbobrovskyi
mbobrovskyi reviewed Mar 7, 2025
View reviewed changes
Copy link
Owner

@mbobrovskyi mbobrovskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also create integration test to check that we can't update not owned chat.

@mbobrovskyi mbobrovskyi added this to the v0.1 milestone Mar 8, 2025
@mbobrovskyi mbobrovskyi added the enhancement New feature or request label Mar 8, 2025
mbobrovskyi
mbobrovskyi reviewed Mar 10, 2025
View reviewed changes
mbobrovskyi
mbobrovskyi reviewed Mar 10, 2025
View reviewed changes
mbobrovskyi
mbobrovskyi reviewed Mar 12, 2025
View reviewed changes
mbobrovskyi
mbobrovskyi reviewed Mar 12, 2025
View reviewed changes
mbobrovskyi
mbobrovskyi reviewed Mar 12, 2025
View reviewed changes
@Horiodino
Implement chat update
292ca9b 
Signed-off-by: Horiodino <[email protected]>
@Horiodino
added test case
af7b810 
Signed-off-by: Horiodino <[email protected]>

fix after review

Signed-off-by: Horiodino <[email protected]>

Implement chat update

Signed-off-by: Horiodino <[email protected]>

added test case

Signed-off-by: Horiodino <[email protected]>
mbobrovskyi
mbobrovskyi reviewed Mar 14, 2025
View reviewed changes
mbobrovskyi
mbobrovskyi reviewed Mar 14, 2025
View reviewed changes
Copy link
Owner

@mbobrovskyi mbobrovskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Thank you so much for your efforts - I really appreciate it!

@Horiodino
fix after review
cb924ca 
Signed-off-by: Horiodino <[email protected]>
@mbobrovskyi mbobrovskyi merged commit 51dac53 into mbobrovskyi:main Mar 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbobrovskyi mbobrovskyi mbobrovskyi approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.1
Development

Successfully merging this pull request may close these issues.

Implement chat update
2 participants
@Horiodino @mbobrovskyi