Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video: Support Changing UDP URL #12618

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HTRamsey
Copy link
Collaborator

Replace #10974

@HTRamsey HTRamsey requested a review from DonLakeFlyer March 28, 2025 17:03
@HTRamsey
Copy link
Collaborator Author

@DonLakeFlyer do you know why we specify "MPEG-TS (h.264)" everywhere? I don't see a reason why h265 isn't supported - the plugin supports it: https://gstreamer.freedesktop.org/documentation/mpegtsdemux/tsdemux.html?gi-language=c

@DonLakeFlyer
Copy link
Contributor

do you know why we specify "MPEG-TS (h.264)" everywhere?

nope

@HTRamsey HTRamsey force-pushed the dev-video-udp-url branch from ca2481d to 532a094 Compare March 31, 2025 17:51
@hamishwillee
Copy link
Contributor

@DonLakeFlyer do you know why we specify "MPEG-TS (h.264)" everywhere? I don't see a reason why h265 isn't supported - the plugin supports it: https://gstreamer.freedesktop.org/documentation/mpegtsdemux/tsdemux.html?gi-language=c

Probably because it was the only option in MAVLink for a long time. We added VIDEO_STREAM_ENCODING_H265 in the last year and at the same time separated the type of stream and the encoding in https://mavlink.io/en/messages/common.html#VIDEO_STREAM_INFORMATION

@DonLakeFlyer
Copy link
Contributor

Sorry @hamishwillee I know next to nothing about the video stuff. I haven't ever had a video vehicle to work with so it's never been something I've dug into. It was all written by Gus Grubba and a contractor that Gus paid for ages ago. And then mostly maintained by the ArdSub folks who are mostly gone now. After 5.0 goes out I hope to acquire the parts for a video multi-rotor vehicle and bring myself up to speed on the whole thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants