Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGNOREME: IVFFLAT improvement and bug fix #21463

Draft
wants to merge 296 commits into
base: main
Choose a base branch
from
Draft

IGNOREME: IVFFLAT improvement and bug fix #21463

wants to merge 296 commits into from

Conversation

cpegeric
Copy link
Contributor

@cpegeric cpegeric commented Feb 27, 2025 •
edited
Loading

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #21417

What this PR does / why we need it:

  • bug fix sample count
  • replace aggexec.cluster_centers by table function ivf_create
  • fix compute centroid to run in multi-thread
  • add ivf_threads_build configuration to control the number of worker threads for build. default is 0 (number of CPU)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aunjgr aunjgr Awaiting requested review from aunjgr aunjgr is a code owner

@ouyuanning ouyuanning Awaiting requested review from ouyuanning ouyuanning is a code owner

@qingxinhome qingxinhome Awaiting requested review from qingxinhome qingxinhome is a code owner

@XuPeng-SH XuPeng-SH Awaiting requested review from XuPeng-SH XuPeng-SH is a code owner

@fengttt fengttt Awaiting requested review from fengttt fengttt is a code owner

@daviszhen daviszhen Awaiting requested review from daviszhen daviszhen will be requested when the pull request is marked ready for review daviszhen is a code owner

@aressu1985 aressu1985 Awaiting requested review from aressu1985 aressu1985 will be requested when the pull request is marked ready for review aressu1985 is a code owner

@heni02 heni02 Awaiting requested review from heni02 heni02 will be requested when the pull request is marked ready for review heni02 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
kind/bug Something isn't working kind/enhancement size/XL Denotes a PR that changes [1000, 1999] lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpegeric @matrix-meow