Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TxnExecuter context missing roleId when executes the DDL statement #20858

Merged
merged 6 commits into from
Dec 23, 2024
Merged

TxnExecuter context missing roleId when executes the DDL statement #20858

merged 6 commits into from
Dec 23, 2024

Conversation

qingxinhome
Copy link
Contributor

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #20760
issue #20761

What this PR does / why we need it:

  1. TxnExecuter context supplements roleID and userID when executes the DDL statement
  2. Schema upgrade framework supplements roleID and userID when exec DDL upgrade SQL

@matrix-meow matrix-meow added the size/S Denotes a PR that changes [10,99] lines label Dec 20, 2024
@mergify mergify bot requested a review from sukki37 December 20, 2024 08:07
@mergify mergify bot added the kind/bug Something isn't working label Dec 20, 2024
@mergify mergify bot merged commit 0635430 into matrixorigin:2.0-dev Dec 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangxu19830126 zhangxu19830126 zhangxu19830126 approved these changes

@LeftHandCold LeftHandCold LeftHandCold approved these changes

@ouyuanning ouyuanning ouyuanning approved these changes

@m-schen m-schen m-schen approved these changes

@daviszhen daviszhen daviszhen approved these changes

@sukki37 sukki37 sukki37 approved these changes

@badboynt1 badboynt1 badboynt1 approved these changes

@aunjgr aunjgr Awaiting requested review from aunjgr aunjgr is a code owner

Assignees
No one assigned
Labels
kind/bug Something isn't working size/M Denotes a PR that changes [100,499] lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@qingxinhome @zhangxu19830126 @LeftHandCold @ouyuanning @m-schen @daviszhen @sukki37 @badboynt1 @matrix-meow