Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherrypick from 2.0.1hotfix to 2.0dev: use fixed function id #20830

Merged

Conversation

daviszhen
Copy link
Contributor

@daviszhen daviszhen commented Dec 19, 2024

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #https://github.com/matrixorigin/MO-Cloud/issues/4627

What this PR does / why we need it:

原因:原先的function id用的是iota递增值。如果在中间新增了函数,会导致后面的id发生变化。
修改:functionid 用const值。新增函数追加用不重复的值。

@daviszhen daviszhen changed the title chrrupdate function id chrrypick from 2.0.1hotfix to 2.0dev: update function id Dec 19, 2024
@mergify mergify bot requested a review from sukki37 December 19, 2024 03:20
@mergify mergify bot added kind/bug Something isn't working kind/enhancement labels Dec 19, 2024
@daviszhen daviszhen changed the title chrrypick from 2.0.1hotfix to 2.0dev: update function id chrrypick from 2.0.1hotfix to 2.0dev: use fixed function id Dec 19, 2024
@daviszhen daviszhen changed the title chrrypick from 2.0.1hotfix to 2.0dev: use fixed function id cherrypick from 2.0.1hotfix to 2.0dev: use fixed function id Dec 19, 2024
@matrix-meow matrix-meow added the size/XL Denotes a PR that changes [1000, 1999] lines label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working kind/enhancement size/XL Denotes a PR that changes [1000, 1999] lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants