Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composite date bytes #20823

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Conversation

daviszhen
Copy link
Contributor

@daviszhen daviszhen commented Dec 19, 2024

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #https://github.com/matrixorigin/MO-Cloud/issues/4648

What this PR does / why we need it:

原因:从profile上分析看,Date转字符串,Appendf耗时较多。

image

修改: Date的格式固定。手工拼接字符串。
year:1~9999。 先对100求商和余数。1~99 查表转字符串。
month: 1~12。查表转字符串。
day:1~31。查表转字符串。

@daviszhen daviszhen requested a review from XuPeng-SH as a code owner December 19, 2024 02:54
@matrix-meow matrix-meow added the size/M Denotes a PR that changes [100,499] lines label Dec 19, 2024
@mergify mergify bot requested a review from sukki37 December 19, 2024 02:55
@daviszhen daviszhen changed the title composite date by handle com Dec 19, 2024
@daviszhen daviszhen changed the title com composite date bytes by hand Dec 19, 2024
@daviszhen daviszhen changed the title composite date bytes by hand composite date bytes Dec 19, 2024
@daviszhen
Copy link
Contributor Author

@mergify refresh

Copy link
Contributor

mergify bot commented Dec 19, 2024

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 8eb5578 into matrixorigin:2.0-dev Dec 19, 2024
18 checks passed
daviszhen added a commit to daviszhen/matrixone that referenced this pull request Dec 24, 2024
原因:从profile上分析看,Date转字符串,Appendf耗时较多。

![image](https://github.com/user-attachments/assets/c5ed4740-00d8-4832-96f3-59207c837a12)

修改: Date的格式固定。手工拼接字符串。
year:1~9999。 先对100求商和余数。1~99 查表转字符串。
month: 1~12。查表转字符串。
day:1~31。查表转字符串。

Approved by: @XuPeng-SH, @sukki37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement size/M Denotes a PR that changes [100,499] lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants