refactor: improve checkTableDefChange #19681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huby2358
requested review from
aunjgr,
XuPeng-SH,
triump2020,
ouyuanning,
badboynt1,
daviszhen,
qingxinhome,
aressu1985 and
heni02
as code owners
badboynt1
approved these changes
Oct 30, 2024
aressu1985
approved these changes
Oct 30, 2024
ouyuanning
approved these changes
Oct 30, 2024
XuPeng-SH
approved these changes
Oct 30, 2024
daviszhen
approved these changes
Oct 30, 2024
aunjgr
approved these changes
Oct 30, 2024
sukki37
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue # #18598
What this PR does / why we need it:
cherry-pick
execute sql 执行的时候， checkTableDefChange里面调用HasNewerVersion判断