-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix KillRoutineConnections panic #18726
Conversation
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here. PR Reviewer Guide 🔍
|
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here. PR Code Suggestions ✨
|
User description
What type of PR is this?
Which issue(s) this PR fixes:
issue #https://github.com/matrixorigin/MO-Cloud/issues/4068 #18764
What this PR does / why we need it:
fix KillRoutineConnections panic
PR Type
Bug fix
Description
KillRoutineConnections
method by adding a check to ensure that the protocol is not nil before attempting to log and kill the connection.Changes walkthrough 📝
routine_manager.go
Fix panic by checking protocol before killing connection
pkg/frontend/routine_manager.go
rt.getProtocol()
before logging and killing theconnection.
killConnection
is only called if the protocol is not nil.