Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow choosing webgl version #5236

Merged
merged 7 commits into from
Dec 18, 2024
Merged

Conversation

ibesora
Copy link
Contributor

@ibesora ibesora commented Dec 18, 2024

Following #5198, this PR allows to use a desired WebGL version by setting contextType inside the canvasContextAttributes option on Map creation.

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@ibesora ibesora changed the title Ib/choose webgl version Allow choosing webgl version Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.83%. Comparing base (ab63cf4) to head (4233f25).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5236   +/-   ##
=======================================
  Coverage   91.82%   91.83%           
=======================================
  Files         281      281           
  Lines       38829    38839   +10     
  Branches     6774     6785   +11     
=======================================
+ Hits        35655    35667   +12     
+ Misses       3045     3044    -1     
+ Partials      129      128    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibesora ibesora merged commit 25be943 into maplibre:main Dec 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants