Fix globe pitch-aligned line-placed texts #4925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4925 +/- ##
==========================================
- Coverage 90.86% 90.50% -0.36%
==========================================
Files 265 265
Lines 38098 38098
Branches 3163 3181 +18
==========================================
- Hits 34616 34480 -136
- Misses 2538 2647 +109
- Partials 944 971 +27 ☔ View full report in Codecov by Sentry. |
|
Looks good to me, thanks! |
HarelM
approved these changes
Oct 29, 2024
jonathanlurie
pushed a commit
to jonathanlurie/maplibre-gl-js
that referenced
this pull request
Oct 30, 2024
* Fix map-pitch-aligned line-placed texts on globe * Add render test * Only use globe text line render tests with collision circles * Add another symbol-visibility/visible expected image * Add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4786, adds render test for this behaviour.
Before:
After: