Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lockfile during install #24

Closed
1 task done
RyanClementsHax opened this issue Feb 26, 2024 · 0 comments · Fixed by #25
Closed
1 task done

Use lockfile during install #24

RyanClementsHax opened this issue Feb 26, 2024 · 0 comments · Fixed by #25
Assignees

Comments

@RyanClementsHax
Copy link
Collaborator

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

When installing, a regular npm install is made which could bump some versions during install. This makes for harder reproductions since installs aren't reproduceable.

Describe the solution you'd like

Install with the versions specified in the lock file. This would then translate to the following install commands.

We use nypm for installing dependencies since it has automatic package manager resolution. It does not currently have an option for using the lock file. I opened one here unjs/nypm#115

In the meantime, we can use execa to execute the command we want.

Teachability, documentation, adoption, migration strategy

No response

What is the motivation / use case for changing the behavior?

This makes for easier reproductions and deterministic output from the cli.

@RyanClementsHax RyanClementsHax self-assigned this Feb 26, 2024
RyanClementsHax added a commit that referenced this issue Feb 26, 2024
- install with "npm ci" instead of "npm install" so package-lock.json is respected
- implement a detected package manager to install command map to preserve behavior of nypm's installDependencies command and prepare for when we want to choose between package managers
- leave a link to the open issue for adding this feature into nypm

Closes #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant