Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up console output when installing project #22

Closed
1 task done
RyanClementsHax opened this issue Feb 26, 2024 · 0 comments · Fixed by #23
Closed
1 task done

Clean up console output when installing project #22

RyanClementsHax opened this issue Feb 26, 2024 · 0 comments · Fixed by #23

Comments

@RyanClementsHax
Copy link
Collaborator

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

When mantis-app init installs the dependencies, many warnings and "vulnerabilities" output to the console. This could be interpreted as a problem by developers who don't know that these are largely noise.

Describe the solution you'd like

Suppress the output from installing and replace it with a Installing dependencies... spinner.

Teachability, documentation, adoption, migration strategy

No response

What is the motivation / use case for changing the behavior?

npm install puts MANY warnings in the console that aren't actually problems for our purposes. In addition, the vulnerability audit at the end is additional noise. Combined, this could confuse a new-comer that the application being created by mantis-app init is sub-standard.

RyanClementsHax added a commit that referenced this issue Feb 26, 2024
- make the install command silent
- output a spinner instead of the normal install output so the user knows what is happening and the cli didn't stall
- output a console line when we start the applications to tell the user what is happening
- rename entrypoint files from mantis to mantis-app to be consistent with the package name we publish to npm

Closes #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant