Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sound/s_dsp.cpp: Updates/Cleanups #13488

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

sound/s_dsp.cpp: Updates/Cleanups #13488

wants to merge 6 commits into from

Conversation

cam900
Copy link
Contributor

@cam900 cam900 commented Mar 17, 2025 •
edited
Loading

  • Fix pitch modulation emulation
  • Fix input clock
  • Fix save state support
  • Fix indent inconsistency
  • Use std::clamp for clamping functions
  • Use reference for voice state
  • Use lowercase hexadecimal values
  • Use logmacro.h for logging

reference: https://snes.nesdev.org/wiki/SNESdev_Wiki

@cam900 cam900 changed the title sound/s_dsp.cpp: Fix pitch modulation emulation, Fix save state support sound/s_dsp.cpp: Updates/Cleanups Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelosa angelosa angelosa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cam900 @angelosa