Skip to content
This repository was archived by the owner on Aug 6, 2023. It is now read-only.

This fixes the problem of new lines being eaten in code blocks in lists #43

Merged
merged 6 commits into from
Dec 16, 2022
Merged

This fixes the problem of new lines being eaten in code blocks in lists #43

merged 6 commits into from
Dec 16, 2022

Conversation

its-teal
Copy link
Contributor

No description provided.

@makew0rld
Copy link
Owner

Thanks for this fix! Another hack on the top of the pile :D

Unfortunately right now it's causing some other tests to fail, specifically some of the ones in test_list.py. You can run pytest to see what the issues are. Basically your change is breaking some spaces in other lists. It's possible those tests are kind of wrong, but the current output is definitely incorrect. Let me know if you think the tests should be changed in some way.

Thanks again!

@its-teal
Copy link
Contributor Author

Oh, I didn't even see those. I wasn't sure how you were running the tests, I ended up kludging together a script to call them.

I'll go take a look and submit an update later.

@its-teal
Copy link
Contributor Author

What tool do you run for the formatting? I didn't notice it until after I pushed, I'm hoping I didn't undo any of it...

@its-teal
Copy link
Contributor Author

Also, pytest runs clean for me with this change.

@makew0rld
Copy link
Owner

I'm using black for formatting, and I run black --exclude 'unitable\.py' md2gemini tests.

@makew0rld
Copy link
Owner

Thanks for this, will merge now. Let me know if you want a release made or anything.

@makew0rld makew0rld merged commit d03e8b7 into makew0rld:master Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants