Skip to content
This repository was archived by the owner on Aug 6, 2023. It is now read-only.

Paragraph end quotes skipping past headings #10

Closed
makew0rld opened this issue Jun 12, 2020 · 5 comments · Fixed by #33
Closed

Paragraph end quotes skipping past headings #10

makew0rld opened this issue Jun 12, 2020 · 5 comments · Fixed by #33
Labels
bug Something isn't working

Comments

@makew0rld
Copy link
Owner

No description provided.

@makew0rld
Copy link
Owner Author

TODO: Create a test case

@makew0rld makew0rld added the bug Something isn't working label Jun 18, 2020
@makew0rld
Copy link
Owner Author

Links inside lists might be playing a role in causing this.

@karlb
Copy link
Contributor

karlb commented Jan 28, 2021

Here's a test case that fails for me:

# Headline

text

* [foo](foo.md)
* [bar](bar.md)

## Sub head

more text

results in

# Headline

text

* foo[1]
* bar[2]

## Sub head

more text

=> foo.md 1: foo.md
=> bar.md 2: bar.md

but should be

# Headline

text

* foo[1]
* bar[2]

=> foo.md 1: foo.md
=> bar.md 2: bar.md

## Sub head

more text

@karlb
Copy link
Contributor

karlb commented Feb 6, 2021

This also has the unpleasant side effect that on a page that only contains lists and headlines, the links are not added at all.

@makew0rld
Copy link
Owner Author

Yikes, I'll look into this. Thanks for the test case and info. If anyone else wants to look into the code that'd be appreciated as well, as I don't necessarily have a lot of time to devote to this right now.

karlb added a commit to karlb/md2gemini that referenced this issue Feb 14, 2021
Also works as regression test for
makew0rld#10.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants