Bugfix to allow seeding via KMS #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skiptomyliu
force-pushed
the
lyft-user-nov-16-2022
branch
from
1ab6f38 to
7058dc8
Compare
meng-han
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bless generates ephemeral certs and relies on entropy to generate these ephemeral keys.
For some reason the lambda in
us-east-1kernel is reporting that we only have 256 bits available from/proc/sys/kernel/random/entropy_avail, whereas bless has a minimum of 2046 bits it uses for random generation that would allow us to securely generate certs.When this occurs, we fallback on using KMS for the random generation, which is currently broken.
us-west-2looks to be unaffected.This PR fixes KMS:
KMS GenerateRandom function returns random bytes.
urandom.writeexpects a string. To write the string to we b64 encode so we're able to seed/dev/urandomto give it extra randomness.