debugging and cleanups #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crates within a workspace aren't supposed to have their own "target" directories. But yet these directories appear when I edit files with vim and YouCompleteMe. Ignoring them makes tools like "rg" more pleasant to use.
Pull Request Test Coverage Report for Build 213
💛 - Coveralls |
|
Hi ! Thank you for these improvements, it looks perfect. Marc-Antoine |
As described here: https://docs.rs/env_logger/0.7.1/env_logger/#capturing-logs-in-tests This boilerplate means that "RUST_LOG=trace cargo test" does the right thing: * logs actually show up * logs are separated by test, even when tests are run in parallel
* Log the depth of elements as they're fetched * Log the starting depth of structs/enums and their Rust symbol names (not just XML element names, which may differ significantly) * Log every element in the struct/enum match loop at trace level. * Log file/line numbers at a few key points in the tests. This is helpful in finding failures happen in some of the longer tests. This logging helps me understand the data flow as I play with changes for luminvent#76.
* "skipped" is unnecessary: it's always false at depth == 0, so its one use in "if depth == 0 && !skipped" can be removed. * the element doesn't need a binding, and shadowing "named_element" confused me. * remove old commented-out path that errored on unknown elements
scottlamb
force-pushed
the
pr-debugging-and-cleanups
branch
from
cf1777f to
8a1e1e2
Compare
|
Fixed. |
|
Anything else I need to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised on #76.
These are intended to be uncontroversial changes, but I can revise/remove stuff if that's not true.