DM-49491: Update Ook with Links API and Cloud SQL #4410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jonathansick
commented
Mar 25, 2025
jonathansick
commented
- The main ook deployment uses the cloud sql proxy sidecar container as an init container
- The ook jobs (audit and ingest-updated) instead use the cloud sql service (because a sidecar container would prevent these jobs from finishing on job exit)
- Dropped the templating of the Kubernetes service account name and instead hard-coded it to "ook" to avoid confusion.
jonathansick
force-pushed
the
tickets/DM-49491
branch
4 times, most recently
from
a3d84f7 to
9f80e2f
Compare
Pull request: lsst-sqre/ook#176
- The main ook deployment along with the jobs (audit and ingest-updated) uses the cloud sql proxy sidecar container as an init container. - Dropped the templating of the Kubernetes service account name and instead hard-coded it to "ook" to avoid confusion.
Simplify the ook chart by hardcoding the name rather than using the fullname template variable. This is something we've been doing in our charts for simplicity given the Phalanx context.
This DRYs out the env var definitions that are mostly needed for mapping secrets and mounted directory paths to environment variables. These are the same for the main deployment and any cron jobs.
- The ingress for /ook/docs should redirect the user to login - The ingress for /ook/ingest requires an admin scope - Other endpoints can be anonymous. Perhaps we'll want a "project member" scope?
jonathansick
force-pushed
the
tickets/DM-49491
branch
from
9f80e2f to
b4163dd
Compare
This job can be toggled on to run an Alembic schema migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.