Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-49618: App Metrics - Fix for apps with no tags #4391

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

DM-49618: App Metrics - Fix for apps with no tags #4391

wants to merge 2 commits into from

Conversation

fajpunk
Copy link
Member

@fajpunk fajpunk commented Mar 21, 2025 •
edited
Loading

Helm blows up if we try to add an app but not add any tags for it.

  • The new unit tests should verify that this case doesn't break anymore
  • I switched data-int to this branch there was no diff, which should verify that this doesn't break existing config
    image

@fajpunk fajpunk force-pushed the tickets/DM-49618/metrics-fix-apps-with-no-tags branch from 439d3cb to 8205e0c Compare March 21, 2025 16:49
@fajpunk fajpunk requested a review from stvoutsin March 21, 2025 16:57
@fajpunk fajpunk force-pushed the tickets/DM-49618/metrics-fix-apps-with-no-tags branch from 8205e0c to 96f5fcf Compare March 21, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stvoutsin stvoutsin Awaiting requested review from stvoutsin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fajpunk