tickets/DM-48511: Fix redis values configuration #4364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fireye04
force-pushed
the
tickets/DM-48511
branch
from
2c296bf to
49b9c74
Compare
afausti
requested changes
Mar 26, 2025
| @@ -110,3 +110,10 @@ redis: | |||
|
|
|||
| # -- Affinity rules for the Redis pod | |||
| affinity: {} | |||
|
|
|||
| cluster: | |||
| name: backpack | |||
There was a problem hiding this comment.
This is the name of the Kafka cluster that backpack uses, i.e "sasquatch"
| name: backpack | ||
|
|
||
| strimzi: | ||
| enabled: true |
There was a problem hiding this comment.
I would just list the Kafka topics you want to create here, assuming that Strimzi is deployed.
|
|
||
| strimzi: | ||
| enabled: true | ||
| topics: [lsst.backpack.usgs-earthquake-data] |
There was a problem hiding this comment.
I suggest you group all configuration related to Kafka for example:
kafka:
cluster:
name: sasquatch
topics:
- lsst.backpack.usgs-earthquake-data
| @@ -0,0 +1,15 @@ | |||
| {{- if .Values.strimzi.enabled }} | |||
There was a problem hiding this comment.
You can't really test this effectively here, so just assume Strimzi is deployed and that backpack depends on it.
| @@ -0,0 +1,15 @@ | |||
| {{- if .Values.strimzi.enabled }} | |||
| {{- $cluster := .Values.cluster.name }} | |||
There was a problem hiding this comment.
With the suggested configuration below, this would become:
{{- $cluster := .Values.kafka.cluster.name }}
| @@ -0,0 +1,15 @@ | |||
| {{- if .Values.strimzi.enabled }} | |||
| {{- $cluster := .Values.cluster.name }} | |||
| {{- range $topic := .Values.strimzi.topics }} | |||
There was a problem hiding this comment.
And this would become:
{{- range $topic := .Values.kafka.topics }}
| replicas: 3 | ||
| partitions: 1 | ||
| {{- end }} | ||
| {{- end }} |
There was a problem hiding this comment.
You can remove the extra end too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.