SP-1929: Adding Rubin rag #4331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The application should really be called "rubin-rag" rather than "rubin_rag" because of conventions in API usage which discourage underscores. (Notice that all existing applications in phalanx use dashes rather than underscores for word separators in their names.) |
|
Everything other than the GitHub repo itself should be named “rubin-rag”. Did I miss something? |
Yes, I think so - api should be |
Update chart to point at correct GitHub repo
JeremyMcCormick
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create rubin-rag from gai-helpers and deploy on data-int.