Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tickets/DM-49490: round up for user domain etc #69

Merged
merged 9 commits into from
Mar 26, 2025
Merged

Conversation

athornton
Copy link
Member

Don't download notebooks, set variables for warning users of degraded mode.

@athornton athornton requested review from rra and stvoutsin March 19, 2025 01:44
@athornton athornton force-pushed the tickets/DM-49490 branch 3 times, most recently from 3b25f62 to a99c209 Compare March 19, 2025 23:22
Copy link
Member

@rra rra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some questions about some of the changes, since they weren't mentioned in the PR description and it wasn't obvious to me what the change did.

@athornton athornton force-pushed the tickets/DM-49490 branch 2 times, most recently from 6a3f945 to 80660ee Compare March 21, 2025 23:08
@athornton athornton requested a review from rra March 24, 2025 15:44
Copy link
Member

@rra rra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but otherwise looks good to me.

@athornton athornton merged commit bdb8f83 into main Mar 26, 2025
4 checks passed
@athornton athornton deleted the tickets/DM-49490 branch March 26, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants