Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SRTT calculations when RTT < 8 ms and SRTT >= 8 ms #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cgutman
Copy link

@cgutman cgutman commented May 16, 2021

This fixes #161 by ensuring that the RTT division always rounds up.

Verified

This commit was signed with the committer’s verified signature.
arvid-norlander Arvid Norlander
@cgutman
Copy link
Author

cgutman commented May 16, 2021

Because this change can cause RTT variance to reach 0 now, you may want to consider a change like cgutman@ad5bf95 to ensure sub-1ms RTT variance will not cause excessive retransmissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect SRTT calculation when SRTT >= 8 and actual RTT < 8 ms
1 participant