fix: expand volume option is greyed under Volume tab but working in the volume detail section #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes adjust the logic governing the "Expand Volume" action in two files. In Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant VA as VolumeActions
participant CC as Condition Checker
U->>VA: Request "Expand Volume" action
VA->>CC: Check if Scheduled.status !== "true"
alt Status is not "true"
CC-->>VA: Condition met
VA-->>U: Enable "Expand Volume" action
else Status is "true"
CC-->>VA: Condition not met
VA-->>U: Disable "Expand Volume" action
end
sequenceDiagram
participant U as User
participant VB as VolumeBulkActions
participant DF as disableExpandVolume
U->>VB: Initiate bulk action for "Expand Volume"
VB->>DF: Evaluate each row's Scheduled status
alt At least one row not "true"
DF-->>VB: Return disable flag
VB-->>U: Disable "Expand Volume" action for bulk selection
else All rows "true"
DF-->>VB: Return flag false
VB-->>U: Enable "Expand Volume" action for bulk selection
end
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
houhoucoop
commented
Mar 18, 2025
| @@ -248,7 +248,7 @@ function actions({ | |||
| }) | |||
|
|
|||
| availableActions.push({ key: 'cloneVolume', name: 'Clone Volume', disabled: selected.standby || isRestoring(selected) }) | |||
| availableActions.push({ key: 'expandVolume', name: 'Expand Volume', disabled: selected?.conditions?.Scheduled?.status?.toLowerCase() === 'false' }) | |||
| availableActions.push({ key: 'expandVolume', name: 'Expand Volume', disabled: selected?.conditions?.Scheduled?.status?.toLowerCase() !== 'true' }) | |||
There was a problem hiding this comment.
Disable the button if the value is false or undefined.
a110605
approved these changes
Mar 18, 2025
Signed-off-by: Yi-Ya Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Expand Volumeshould be consistent across the volume details page and bulk actionsExpand Volumeshould be enabled for detached volumeIssue
[BUG] Expand Volume option is greyed under Volume tab but working in the volume detail section. #7529
Test Result
Expand Volumeoption should be enabledExpand Volumeshould also be enabled thereAdditional documentation or context
N/A
Summary by CodeRabbit