Configurable parametersLimit

[dougwilson]

It would be nice if the second parameter was just an object to specify the options like the separator, parametersLimit, etc. Or maybe copy the interface of https://github.com/joyent/node/blob/v0.10.24/lib/querystring.js#L160 (though I think just a single second options argument is good enough).

Inspiration: expressjs/body-parser#41

[nlf]

I agree completely, this goes along nicely with #18 as well.

[nlf]

Closed via a5422fc

[dougwilson]

Holy moley, parsing a flat list of 2000 parameters takes 1710ms on my machine, but < 10ms for querystring module. I don't think allowing over 1000 is even feasible with this module, haha.

[dougwilson]

(P.S. yes, I understand this module does more than querystring, just it was the only thing to really compare to :) )

[dougwilson]

Looks like for my test, the clone occurring at the top of Utils.merge is causing all the slow down (https://github.com/hapijs/qs/blob/master/lib/utils.js#L52). It doesn't even seem necessary to do in this module? Removing that single clone for me bring down the 2000 parameter parse time to like < 10ms just like querystring.

[nlf]

Hmm.. I think you're right and we don't need the clone, since we're never calling merge on user input and we don't care if we mutate our own object. I'll open a new issue.