Added PostgreSQL support #160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamdes
reviewed
Mar 21, 2025
| /** | ||
| * HostMapper class implementation for MariaDB | ||
| */ | ||
| class HostMapper implements HostMapperInterface |
There was a problem hiding this comment.
could it not extend the MySQL one if there is no changes to the implementation ?
There was a problem hiding this comment.
Implementation is slightly different, I had to remove all backticks from sql queries to make it work
sure there's a lot of duplicate code :(
There was a problem hiding this comment.
maybe all implementations could benefit from a function to quote column names @liuch ?
williamdes
reviewed
Mar 21, 2025
| @@ -22,7 +22,8 @@ | |||
| "league/flysystem-aws-s3-v3": "^2.5 || ^3.25.1" | |||
| }, | |||
| "suggest": { | |||
| "ext-imap": "Needed to process incoming DMARC reports stored in a mailbox" | |||
| "ext-imap": "Needed to process incoming DMARC reports stored in a mailbox", | |||
| "ext-pdo_pgsql": "Needed to use Postgresql" | |||
There was a problem hiding this comment.
Should we not move ext-pdo_mysql here too ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for PostgreSQL i made at work to test your tool