feat: add_providers to easily add new type provider #659
+44
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofin
approved these changes
Mar 15, 2025
provinzkraut
approved these changes
Mar 16, 2025
|
Friendly reminder on this pull request. Please provide any updates or additional information if needed. |
adhtruong
reviewed
Mar 16, 2025
| @@ -184,10 +184,14 @@ class BaseFactory(ABC, Generic[T]): | |||
| _factory_type_mapping: ClassVar[dict[Any, type[BaseFactory[Any]]]] | |||
| _base_factories: ClassVar[list[type[BaseFactory[Any]]]] | |||
|
|
|||
| _providers: ClassVar[dict[Any, Callable[[], Any]]] | |||
| "List of type providers that apply to all factories" | |||
There was a problem hiding this comment.
Suggested change
| "List of type providers that apply to all factories" | |
| """Mapping of type providers that apply to all factories""" |
update to match format of other class doc
| # Non-public attributes | ||
| _extra_providers: dict[Any, Callable[[], Any]] | None = None | ||
| "Used to copy providers from once base factory to another dynamically generated factory for a class" |
There was a problem hiding this comment.
Suggested change
| "Used to copy providers from once base factory to another dynamically generated factory for a class" | |
| """Used to copy providers from once base factory to another dynamically generated factory for a class""" |
update to match format of other class doc
Without modifying the factory class. This enables 3rd party custom types to easily add providers.
|
Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/659 |
|
Just a friendly reminder on this pull request! Let me know if there's anything else that needs to be addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without modifying the factory class. This enables 3rd party custom types to easily add providers.