Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement List Email in Mailbox #8

Merged
merged 7 commits into from
Aug 13, 2021
Merged

Implement List Email in Mailbox #8

merged 7 commits into from
Aug 13, 2021

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Aug 4, 2021 •
edited
Loading

  • Parsing GetEmailMethod
  • Parsing QueryEmailMethod
  • Parsing GetEmailResponse
  • Parsing QueryEmailResponse
  • Implement unit test GetListEmail on docker

@hoangdat
Copy link
Member

hoangdat commented Aug 5, 2021

I did not see the existence of FilterOperator, FilterCondition and Comparator.

@dab246 dab246 changed the title Add Get List Emails Implement List Email in Mailbox Aug 6, 2021
@dab246 dab246 requested a review from hoangdat August 6, 2021 05:01
@chibenwa
Copy link
Member

chibenwa commented Aug 6, 2021

BTW would be awesome if you find some time to record a little video for your work before the weekend.

@hoangdat
Copy link
Member

hoangdat commented Aug 6, 2021

BTW would be awesome if you find some time to record a little video for your work before the weekend.

it is client-library, so IMO, you should to waiting for UI implementation. I will take care this PR. dont worry

hoangdat
hoangdat reviewed Aug 6, 2021
View reviewed changes
hoangdat
hoangdat reviewed Aug 6, 2021
View reviewed changes
@dab246 dab246 force-pushed the get_threads branch 3 times, most recently from 822c84a to 60eee3b Compare August 9, 2021 14:52
hoangdat
hoangdat reviewed Aug 10, 2021
View reviewed changes
@dab246 dab246 force-pushed the get_threads branch 3 times, most recently from 189cfa9 to f6c9430 Compare August 10, 2021 10:37
@hoangdat hoangdat merged commit e42b6e8 into linagora:master Aug 13, 2021
This was referenced Aug 19, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chibenwa chibenwa chibenwa left review comments

@hoangdat hoangdat hoangdat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dab246 @hoangdat @chibenwa