Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Built-in check for Symfony Messenger queue size #277

Merged
merged 5 commits into from
Jan 23, 2023

Conversation

rothfahl
Copy link
Contributor

This adds the ability to configure checks, that ensure that the count of messages in Symfony Messenger transports does not exceed expected limits. It uses MessageCountAwareInterface and therefore only works for transports that implement that interface.

Dear maintainers, we implemented similar checks in several projects. I've now ported that into a feature on library level. Please let me know, if you don't consider it as in scope of this project or if i need to add/change anything before it can be merged.

uses symfony messengers MessageCountAwareInterface to implement a queue size check
munterkofler

This comment was marked as off-topic.

Copy link
Collaborator

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Co-authored-by: Kevin Bond <[email protected]>
@kbond
Copy link
Collaborator

kbond commented Jan 23, 2023

Don't worry about the CI problems. I'll have a look after merging.

Do you mind updating the config docs here: https://github.com/liip/LiipMonitorBundle#full-default-config

@kbond
Copy link
Collaborator

kbond commented Jan 23, 2023

Thanks @rothfahl!

@kbond kbond merged commit 1142f26 into liip:master Jan 23, 2023
@rothfahl
Copy link
Contributor Author

thank you @kbond!

@rothfahl rothfahl deleted the feature/messenger_transport_check branch January 24, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants