Use lexical bindings and misc cleanups #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a keyword to make package linters happy (this is the same keyword whitespace-mode uses). - Explicitly depend on Emacs 24.3 (required to assume that cl-lib is built-in).
This appears to be used precisely once in one of the tests.
Checkdoc wasn't happy about the quoting in the documentation here unless I broke it out into a separate function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this PR primarily to enable lexical bindings so that next time the Emacs devs discuss turning it on by default there will be fewer packages in the wild using dynamic-scoping.
While I was at it, I fixed the rest of the compiler/checkdoc warnings (see the commit messages). I have no special attachment to any of these changes or to this PR so feel free to close it, discard whatever you don't want, etc.