ProblemDetails no longer implements Error #8078
Merged
+92
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
force-pushed
the
prob-not-error
branch
from
fb0e1ee to
474e9d5
Compare
jprenken
previously approved these changes
Mar 26, 2025
beautifulentropy
requested changes
Mar 27, 2025
jprenken
approved these changes
Mar 28, 2025
beautifulentropy
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the .Error() method from probs.ProblemDetails, so that it can no longer be returned from functions which return an error. Update various call sites to use the .String() method to get a textual representation of the problem instead. Simplify ProblemDetailsForError to not special-case and pass-through ProblemDetails, since they are no longer a valid input to that function.
This reduces instances of "boxed nil" bugs, and paves the way for all of the WFE methods to be refactored to simply return errors instead of writing them directly into the response object.
Part of #4980
Warning
Do not merge before #8076 and #8077.